Fix image loading in normalMap sample #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Merge
…aders, texture loading, or maps need work
…nctions, and added additional comments to code
|
Got rid of any utils outside of the main function that handled loading images. I also put all the images back in the assets folder. For some reason, the .next folder and out folder only build in the assets as part of the website when the images are referenced in main? Not sure why that might be. Regardless, image loading should be fixed after this next commit. |
|
This should probably be addressed as soon as possible, the current example on the website is nonfunctional. |
greggman
requested changes
Oct 28, 2023
src/sample/texturedCube/main.ts
Outdated
| @@ -110,6 +110,11 @@ const init: SampleInit = async ({ canvas, pageState }) => { | |||
| // Fetch the image and upload it into a GPUTexture. | |||
| let cubeTexture: GPUTexture; | |||
| { | |||
| const url = new URL( | |||
There was a problem hiding this comment.
why is this changed? revert?
greggman
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the image loading in the normalMap sample to actually work.